Split node.py into multiple files #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying infrahub-sdk-python with
|
| Latest commit: |
5a27695
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0a0dae1.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://dga-20250512-node.infrahub-sdk-python.pages.dev |
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## develop #409 +/- ##
===========================================
+ Coverage 75.10% 75.16% +0.06%
===========================================
Files 93 100 +7
Lines 8560 8613 +53
Branches 1678 1689 +11
===========================================
+ Hits 6429 6474 +45
+ Misses 1677 1676 -1
- Partials 454 463 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
ajtmccarty
approved these changes
May 12, 2025
dgarros
force-pushed
the
dga-20250512-node
branch
from
6fffea9 to
5a27695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is splitting the
node.pyinto multiple files, it's currently close to 800 lines long.To reduce the risk of side effect, I haven't changed the content of the file, with the exception that in some places we are now using Protocols to avoid some circular dependencies.
The change is expected to be backward compatible because everything that was part of
node.pyis exposed frominfrahub_sdk.node